Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: error messages are passed using error key #937

Merged
merged 1 commit into from
Feb 7, 2024
Merged

fix: error messages are passed using error key #937

merged 1 commit into from
Feb 7, 2024

Conversation

ferrandiaz
Copy link
Contributor

I hereby confirm that I followed the code guidelines found at engineering guidelines

Affected Components

  • CLI
  • Create CLI
  • Test
  • Docs
  • Examples
  • Other

Notes for the Reviewer

We are using error key on the api for populating the error message when triggering test on the CLI

@shortcut-integration Shortcut Integration
Copy link

This pull request has been linked to Shortcut Story #17604: Add better error message for npx checkly test when check size exceeds limit.

@ferrandiaz ferrandiaz merged commit fd4c60d into main Feb 7, 2024
3 checks passed
@ferrandiaz ferrandiaz deleted the ferran/sc-17604/check-size-limit branch February 7, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clample clample clample approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ferrandiaz @clample