Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add alertSettings.parallelRunFailureTreshold to CLI [sc-19200] #938

Conversation

maxigimenez
Copy link
Member

I hereby confirm that I followed the code guidelines found at engineering guidelines

Affected Components

  • CLI
  • Create CLI
  • Test
  • Docs
  • Examples
  • Other

Notes for the Reviewer

Add new alert settings options:

alertEscalationPolicy: {
    parallelRunFailureThreshold: {
      enabled: true,
      percentage: 100,
    }
  }

Copy link

Comment on lines +13 to +14
enabled?: boolean,
percentage?: number,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want them to be optional?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If they're missing the BE schema should apply default values

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should be the case yes, it fallback always to the schema defaults

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've follow the same pattern as the other alertSettings props in this file

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, it's weird the enabled is optional and defaults to something though but anyway LGTM

Comment on lines +13 to +14
enabled?: boolean,
percentage?: number,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, it's weird the enabled is optional and defaults to something though but anyway LGTM

@maxigimenez maxigimenez merged commit bfc68da into main Feb 8, 2024
3 checks passed
@maxigimenez maxigimenez deleted the maxigimenez/sc-19200/add-alertsetting-parallelrunfailurethreshold branch February 8, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants