-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add alertSettings.parallelRunFailureTreshold to CLI [sc-19200] #938
feat: add alertSettings.parallelRunFailureTreshold to CLI [sc-19200] #938
Conversation
This pull request has been linked to Shortcut Story #19200: Add alertSetting.parallelRunFailureThreshold support to CLI/TF. |
enabled?: boolean, | ||
percentage?: number, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want them to be optional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If they're missing the BE schema should apply default values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That should be the case yes, it fallback always to the schema defaults
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've follow the same pattern as the other alertSettings props in this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, it's weird the enabled
is optional and defaults to something though but anyway LGTM
enabled?: boolean, | ||
percentage?: number, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, it's weird the enabled
is optional and defaults to something though but anyway LGTM
I hereby confirm that I followed the code guidelines found at engineering guidelines
Affected Components
Notes for the Reviewer
Add new alert settings options: