feat: increase test session timeout #954
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby confirm that I followed the code guidelines found at engineering guidelines
Affected Components
Notes for the Reviewer
Currently both
npx checkly test
andnpx checkly trigger
support a--timeout
flag. This is a fallback timeout to make sure that if the Checkly backend doesn't respond with a check result for some reason, the user's CI doesn't become stuck indefinitely.When it was originally added, there were few users of the CLI and checks ran on AWS Lambda which was able to run all checks concurrently. Now, users have very large test suites which can take longer, and have sometimes bumped into the default 300 second timeout. We'll also be adding test retries which will further increase the time tests take.
This PR simply bumps the default timeout to 10 minutes so that users are less likely to run into it.