Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: increase test session timeout #954

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Conversation

clample
Copy link
Collaborator

@clample clample commented Jul 19, 2024

I hereby confirm that I followed the code guidelines found at engineering guidelines

Affected Components

  • CLI
  • Create CLI
  • Test
  • Docs
  • Examples
  • Other

Notes for the Reviewer

Currently both npx checkly test and npx checkly trigger support a --timeout flag. This is a fallback timeout to make sure that if the Checkly backend doesn't respond with a check result for some reason, the user's CI doesn't become stuck indefinitely.

When it was originally added, there were few users of the CLI and checks ran on AWS Lambda which was able to run all checks concurrently. Now, users have very large test suites which can take longer, and have sometimes bumped into the default 300 second timeout. We'll also be adding test retries which will further increase the time tests take.

This PR simply bumps the default timeout to 10 minutes so that users are less likely to run into it.

@clample clample requested a review from ferrandiaz July 19, 2024 12:57
Copy link
Contributor

@ferrandiaz ferrandiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⏲️

@clample clample enabled auto-merge (squash) July 19, 2024 12:59
@clample clample merged commit 440b851 into main Jul 19, 2024
3 checks passed
@clample clample deleted the chrislample/increase-test-timeout branch July 19, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants