Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly track check state for checkly-trigger #955

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

clample
Copy link
Collaborator

@clample clample commented Jul 24, 2024

I hereby confirm that I followed the code guidelines found at engineering guidelines

Affected Components

  • CLI
  • Create CLI
  • Test
  • Docs
  • Examples
  • Other

Notes for the Reviewer

When running npx checkly trigger, the summary always lists the checks as "scheduling" even when they're completed. The root cause is that the CLI isn't calling the reporter on the CHECK_INPROGRESS event to mark the check is started. This is already correctly set for the npx checkly test command:

runner.on(Events.CHECK_INPROGRESS, (check: any, checkRunId: CheckRunId) => {
reporters.forEach(r => r.onCheckInProgress(check, checkRunId))
})

@clample clample requested a review from ferrandiaz July 24, 2024 07:19
@clample clample merged commit 89dce39 into main Jul 24, 2024
3 checks passed
@clample clample deleted the chrislample/fix-checkly-trigger-bug branch July 24, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants