fix: correctly track check state for checkly-trigger #955
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby confirm that I followed the code guidelines found at engineering guidelines
Affected Components
Notes for the Reviewer
When running
npx checkly trigger
, the summary always lists the checks as "scheduling" even when they're completed. The root cause is that the CLI isn't calling the reporter on theCHECK_INPROGRESS
event to mark the check is started. This is already correctly set for thenpx checkly test
command:checkly-cli/packages/cli/src/commands/test.ts
Lines 251 to 253 in 440b851