Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add environment secrets support [sc-21028] #964

Merged
merged 4 commits into from
Sep 3, 2024
Merged

feat: add environment secrets support [sc-21028] #964

merged 4 commits into from
Sep 3, 2024

Conversation

maxigimenez
Copy link
Member

@maxigimenez maxigimenez commented Aug 28, 2024 •
edited
Loading

I hereby confirm that I followed the code guidelines found at engineering guidelines

Affected Components

  • CLI
  • Create CLI
  • Test
  • Docs
  • Examples
  • Other

Notes for the Reviewer

  • Add --secret support while creating/updating environment variables with npx checkly env add|update
  • Add secret: boolean support for check/group constructs
  • Update npx checkly env pull to structure the file with regular and secret variables

Important

Important note: this feature is not available yet, if you have any questions feel free to reach out to our customer support

@maxigimenez maxigimenez marked this pull request as ready for review August 29, 2024 10:59
@maxigimenez maxigimenez added the build Issue regarding building and packaging label Aug 29, 2024
@github-actions GitHub Actions
Copy link

🎉 Experimental release successfully published on npm

npm install checkly@0.0.0-pr.964.1aa6287

@Antoine-C
Copy link
Contributor

Reviewing 👀

Antoine-C
Antoine-C previously approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@Antoine-C Antoine-C left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit, otherwise LGTM

@maxigimenez maxigimenez merged commit 2630e9e into main Sep 3, 2024
3 checks passed
@maxigimenez maxigimenez deleted the maxigimenez/sc-21028/add-secret-support-to-cli-env-add-command branch September 3, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antoine-C Antoine-C Antoine-C approved these changes

@drakirnosslin drakirnosslin Awaiting requested review from drakirnosslin

Assignees
No one assigned
Labels
build Issue regarding building and packaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxigimenez @Antoine-C @drakirnosslin