Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CxFlow Email Enhancements #337

Merged
11 commits merged into from
Jul 16, 2020
Merged

CxFlow Email Enhancements #337

11 commits merged into from
Jul 16, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jul 9, 2020

By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Changes done to the email functionality in cxflow

Testing

Manual Testing done.

Checklist

  • I have added documentation for new/changed functionality in this PR (if applicable). If documentaiton is a Wiki Update, please indicate desired changes within PR MD Comment
  • [] All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used

@ghost ghost requested review from kmcdon83, alex-ko-dev and AvivCx July 9, 2020 21:24
@cxflowtestuser
Copy link
Collaborator

Scan submitted to Checkmarx

@cxflowtestuser
Copy link
Collaborator

Checkmarx scan completed

Full Scan Details

Checkmarx Scan Summary

Severity Count
High 0
Medium 112
Low 1390
Informational 51

Violation Summary

Severity Count

Details

Lines Severity Category File Link

@cxflowtestuser
Copy link
Collaborator

Scan submitted to Checkmarx

@cxflowtestuser
Copy link
Collaborator

Checkmarx scan completed

Full Scan Details

Checkmarx Scan Summary

Severity Count
High 0
Medium 112
Low 1390
Informational 51

Violation Summary

Severity Count

Details

Lines Severity Category File Link

alex-ko-dev
alex-ko-dev reviewed Jul 12, 2020
View reviewed changes
Copy link
Contributor

@alex-ko-dev alex-ko-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several small suggestions.

src/main/java/com/checkmarx/flow/config/FlowConfig.java Outdated Show resolved Hide resolved
src/main/java/com/checkmarx/flow/config/FlowConfig.java Outdated Show resolved Hide resolved
src/main/java/com/checkmarx/flow/config/FlowProperties.java Outdated Show resolved Hide resolved
src/main/java/com/checkmarx/flow/service/EmailService.java Outdated Show resolved Hide resolved
src/main/java/com/checkmarx/flow/service/EmailService.java Outdated Show resolved Hide resolved
src/main/java/com/checkmarx/flow/service/EmailService.java Outdated Show resolved Hide resolved
src/main/java/com/checkmarx/flow/service/EmailService.java Outdated Show resolved Hide resolved
src/main/java/com/checkmarx/flow/service/EmailService.java Show resolved Hide resolved
src/main/java/com/checkmarx/flow/service/EmailService.java Outdated Show resolved Hide resolved
src/main/java/com/checkmarx/flow/service/SastScanner.java Outdated Show resolved Hide resolved
@cxflowtestuser
Copy link
Collaborator

Scan submitted to Checkmarx

@ghost ghost force-pushed the pr-ts-feature/email-enhancement branch from 0eeed33 to d2597f6 Compare July 13, 2020 16:41
@cxflowtestuser
Copy link
Collaborator

Scan submitted to Checkmarx

@cxflowtestuser
Copy link
Collaborator

Checkmarx scan completed

Full Scan Details

Checkmarx Scan Summary

Severity Count
High 0
Medium 112
Low 1382
Informational 51

Violation Summary

Severity Count

Details

Lines Severity Category File Link

@cxflowtestuser
Copy link
Collaborator

Checkmarx scan completed

Full Scan Details

Checkmarx Scan Summary

Severity Count
High 0
Medium 112
Low 1382
Informational 51

Violation Summary

Severity Count

Details

Lines Severity Category File Link

@cxflowtestuser
Copy link
Collaborator

Scan submitted to Checkmarx

@cxflowtestuser
Copy link
Collaborator

Checkmarx scan completed

Full Scan Details

Checkmarx Scan Summary

Severity Count
High 0
Medium 112
Low 1382
Informational 51

Violation Summary

Severity Count

Details

Lines Severity Category File Link

@cxflowtestuser
Copy link
Collaborator

Scan submitted to Checkmarx

@cxflowtestuser
Copy link
Collaborator

Checkmarx scan completed

Full Scan Details

Checkmarx Scan Summary

Severity Count
High 0
Medium 112
Low 1382
Informational 51

Violation Summary

Severity Count

Details

Lines Severity Category File Link

@ghost
Copy link
Author

ghost commented Jul 13, 2020

Hi @AvivCx , I think one of the component test (GetResultsAnalyticsTestSteps) is failing because the emailService (from ResultService) is null. Can you please ask someone from your team to take a look and confirm?

@AvivCx
Copy link
Contributor

AvivCx commented Jul 14, 2020

@NimrodGolan can you please help Mithilesh to fix this component test?

@ghost ghost force-pushed the pr-ts-feature/email-enhancement branch from 3682f39 to c9f6931 Compare July 14, 2020 23:20
@cxflowtestuser
Copy link
Collaborator

Scan submitted to Checkmarx

1 similar comment
@cxflowtestuser
Copy link
Collaborator

Scan submitted to Checkmarx

@cxflowtestuser
Copy link
Collaborator

Checkmarx scan completed

Full Scan Details

Checkmarx Scan Summary

Severity Count
High 0
Medium 0
Low 0
Informational 0

Violation Summary

Severity Count

Details

Lines Severity Category File Link

@cxflowtestuser
Copy link
Collaborator

Scan submitted to Checkmarx

@cxflowtestuser
Copy link
Collaborator

Checkmarx scan completed

Full Scan Details

Checkmarx Scan Summary

Severity Count
High 0
Medium 0
Low 0
Informational 0

Violation Summary

Severity Count

Details

Lines Severity Category File Link

@cxflowtestuser
Copy link
Collaborator

Scan submitted to Checkmarx

@cxflowtestuser
Copy link
Collaborator

Checkmarx scan completed

Full Scan Details

Checkmarx Scan Summary

Severity Count
High 0
Medium 0
Low 0
Informational 0

Violation Summary

Severity Count

Details

Lines Severity Category File Link

Mithilesh Pawar added 2 commits July 15, 2020 16:12
Added support for providing static list of emails.
272b344 
Also added FileTemplateResolver to provide external email templates.
Changed the Mail's 'enable' flag to 'notification'.
f4aa085 
Added extra flag 'allow-empty-mail' to provide the choice for email notification when no issues are found.
@ghost ghost force-pushed the pr-ts-feature/email-enhancement branch from a37c3d8 to 1c4e39d Compare July 15, 2020 20:12
@cxflowtestuser
Copy link
Collaborator

Scan submitted to Checkmarx

@cxflowtestuser
Copy link
Collaborator

Checkmarx scan completed

Full Scan Details

Checkmarx Scan Summary

Severity Count
High 0
Medium 0
Low 0
Informational 0

Violation Summary

Severity Count

Details

Lines Severity Category File Link

@sonarcloud
Copy link

sonarcloud bot commented Jul 15, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@ghost
Copy link
Author

ghost commented Jul 15, 2020

@NimrodGolan , @AvivCx thanks for your support, the tests are all green now.

@ghost ghost merged commit 4e38380 into develop Jul 16, 2020
@AvivCx AvivCx deleted the pr-ts-feature/email-enhancement branch September 1, 2020 15:19
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmcdon83 kmcdon83 Awaiting requested review from kmcdon83

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cxflowtestuser @AvivCx @alex-ko-dev