Pr orly ast support #356
Merged
Pr orly ast support #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Scan submitted to Checkmarx |
Checkmarx scan completedCheckmarx Scan Summary
Violation Summary
Details
|
AvivCx
approved these changes
Jul 23, 2020
alex-ko-dev
reviewed
Jul 23, 2020
| ScanResults scaScanResults = null; | ||
| ScanResults astScanResults = null; | ||
|
|
||
| if(isSastEnabled()) { |
There was a problem hiding this comment.
Can we use a 'for' loop here or reuse the existing one?
| @@ -451,8 +453,7 @@ private String getOptionValues(ApplicationArguments arg, String option){ | |||
| } | |||
|
|
|||
| private void cxScan(ScanRequest request, String gitUrl, String gitAuthUrl, String branch, ScanRequest.Repository repoType) throws ExitThrowable { | |||
There was a problem hiding this comment.
Can we use a more meaningful name instead of cxScan()? It's not clear by looking at the code what is the difference between cxScan() and scan().
| } | ||
|
|
||
| private boolean isAstEnabled() { | ||
| return flowProperties.getEnabledVulnerabilityScanners().contains(AST_SCANNER); |
There was a problem hiding this comment.
Are there cases when getEnabledVulnerabilityScanners() returns null?
| Files.deleteIfExists(Paths.get(cxZipFile)); | ||
|
|
||
| } catch (Exception e) { | ||
| final String message = "SCA scan failed."; |
There was a problem hiding this comment.
Looks like 'scanType' should be used here instead of SCA.
Comment on lines
+56
to
+60
| final String message = "SCA scan failed."; | ||
| log.error(message, e); | ||
| OperationResult scanCreationFailure = new OperationResult(OperationStatus.FAILURE, e.getMessage()); | ||
| logRequest(scanRequest, getScanId(internalResults), scanCreationFailure); | ||
| throw new MachinaRuntimeException(message); |
There was a problem hiding this comment.
Please resolve this code duplication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring to allow AST support
Existing tests on SCA should cover all the changes