Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Issue #360 : Added PR feedback in case of existing active scan. #375

Merged
merged 3 commits into from
Aug 10, 2020

Conversation

ghost
Copy link

@ghost ghost commented Aug 7, 2020

By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

This fixes the issue #360 by adding feedback for PR when there's an active scan running in checkmarx for the same project.
This would update the PR status accordingly and also post a comment for the same. This works for all the repos.

References

#360

Testing

Manual testing done by keeping the scan-resubmit flag set to false.

Checklist

  • I have added documentation for new/changed functionality in this PR (if applicable). If documentation is a Wiki Update, please indicate desired changes within PR MD Comment
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used

@ghost ghost added the bug Something isn't working label Aug 7, 2020
@ghost ghost requested review from kmcdon83, alex-ko-dev and AvivCx August 7, 2020 03:26
@sonarcloud
Copy link

sonarcloud bot commented Aug 10, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_265) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@kmcdon83 kmcdon83 merged commit 9c1015d into develop Aug 10, 2020
@ghost ghost deleted the pr-ts-bugfix/360-PR-feedback-for-existing-scan branch August 27, 2020 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants