Added support for multiple optional SCM's instances #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AvivCx
approved these changes
Aug 18, 2020
james-bostock-cx
pushed a commit
to james-bostock-cx/cx-flow
that referenced
this pull request
Mar 18, 2021
* Introduce new scmInstance property * Repo properties have a new optionalInstances map property * Set scmInstance as an integrate scanRequest member property * Determine GitHub SCM config overrider for token & api-uri params * Determine webhook token on scm config overrider * In case a wrong scm-instance was defined throw an exception * Determine api-url on scm config overrider * Determine token on scm config overrider * Set DTO getters & setters * Set scm instance on pullRequest flow * Add scm overrider logs * Set scmConfigOverrider property on failed tests * Add validation also for scan request scm instance * Add new multi-scm integration test * Set determineConfigToken method with a generic string param
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
References
Testing
Integration test with optional instance was created, while default configuration is on comment-out