Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Remove hard coded auto profile setting to TRUE on GitHubController flow #397

Merged
merged 1 commit into from
Aug 20, 2020

Conversation

NimrodGolan
Copy link
Contributor

this is a clone of PR #368

Description

This fixes a breaking issue for our environment. We have the autoProfile property set to false in our environment, because when autoProfile is enabled, CxFlow hits an exception during commit & PR events when it calls the profile-related GitHub APIs (perhaps because the GitHub Enterprise service account we use does not have the needed scopes/permissions for those APIs) and so that exception causes processing of those event to fail and CxFlow doesn't create the project and/or kick off Checkmarx scans. I think it's apparent that the line this PR deletes was a typo anyway, because it globally overrides the autoProfile property on branch deletion events, so we would see things working as normal (autoProfile disabled) until a branch deletion event was processed, at which point all other events started failing since autoProfile was enabled.

Checklist

  • I have added documentation for new/changed functionality in this PR (if applicable). If documentaiton is a Wiki Update, please indicate desired changes within PR MD Comment
  • [X ] All active GitHub checks for tests, formatting, and security are passing
  • [X ] The correct base branch is being used

@NimrodGolan NimrodGolan merged commit f2275bd into develop Aug 20, 2020
@NimrodGolan NimrodGolan deleted the pr-368-remove-auto-profile-property branch August 20, 2020 12:30
james-bostock-cx pushed a commit to james-bostock-cx/cx-flow that referenced this pull request Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants