Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Issue #405 : Exception thrown in case of blank email template name. #407

Merged
1 commit merged into from
Aug 31, 2020
Merged

Fixes Issue #405 : Exception thrown in case of blank email template name. #407

1 commit merged into from
Aug 31, 2020

Conversation

ghost
Copy link

@ghost ghost commented Aug 31, 2020

Description

This PR fixes an issue with email template, where an exception was being thrown in case the template name was blank. Added a mechanism to use a cxflow's default template.

References

#405

Testing

Manual Testing done using GitHub webhooks.

Checklist

  • I have added documentation for new/changed functionality in this PR (if applicable). If documentaiton is a Wiki Update, please indicate desired changes within PR MD Comment
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used

Issue #405 : Resolves the issue where an exception was thrown in case…
5b55b35 
… of blank template name provided in the application yml.
@ghost ghost added the bug Something isn't working label Aug 31, 2020
@ghost ghost requested review from kmcdon83 and AvivCx August 31, 2020 13:46
AvivCx
AvivCx reviewed Aug 31, 2020
View reviewed changes
Copy link
Contributor

@AvivCx AvivCx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MithileshPawar
can you share the automation that we added for email notification flow in general?

@ghost ghost merged commit 3c0a456 into develop Aug 31, 2020
@AvivCx AvivCx deleted the pr-ts-bugfix/405-email-template-exception branch September 1, 2020 15:19
james-bostock-cx pushed a commit to james-bostock-cx/cx-flow that referenced this pull request Mar 18, 2021
Issue checkmarx-ltd#405 : Resolves the issue where an exception was t…
32a3520 
…hrown in case of blank template name provided in the application yml. (checkmarx-ltd#407)
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmcdon83 kmcdon83 Awaiting requested review from kmcdon83

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AvivCx