Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub App Support for GitHub Issues #513

Merged
merged 3 commits into from
Nov 10, 2020
Merged

Conversation

kmcdon83
Copy link
Contributor

By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Logic was missing to incorporate GitHub App authentication for GitHub Issues Integration. This PR has updated the logic to include this support.

References

Fixes #511

Testing

Testing was conducted using published GitHub App for kmcdon83/DVWA

Checklist

  • I have added documentation for new/changed functionality in this PR (if applicable). If documentaiton is a Wiki Update, please indicate desired changes within PR MD Comment
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used

@kmcdon83 kmcdon83 requested a review from AvivCx November 10, 2020 02:42
@sonarcloud
Copy link

sonarcloud bot commented Nov 10, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_265) you have used to run this analysis is deprecated and we will stop accepting it accepting it soon.Please update to at least Java 11.
Read more here

@AvivCx AvivCx merged commit 3da1556 into develop Nov 10, 2020
@AvivCx AvivCx deleted the pr-fix/github-app-issues branch November 16, 2020 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub App does not support GitHub Issues
2 participants