Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: restore cpBlocksCache if processing failed #259

Merged
merged 1 commit into from
Sep 27, 2023
Merged

fix: restore cpBlocksCache if processing failed #259

merged 1 commit into from
Sep 27, 2023

Conversation

Sekhmet
Copy link
Contributor

@Sekhmet Sekhmet commented Sep 27, 2023

Currently it's possible that processing fails and block won't be retried because it was in cpBlocksCache and got removed before processing. We need to restore it back.

Test plan

  • Throw in some handler (for example handleVote).
  • Run server.
  • It keeps retrying instead of skipping.

@Sekhmet Sekhmet requested a review from bonustrack September 27, 2023 10:59
@Sekhmet Sekhmet self-assigned this Sep 27, 2023
bonustrack
bonustrack approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@bonustrack bonustrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@Sekhmet Sekhmet merged commit 71473ab into master Sep 27, 2023
1 check passed
@Sekhmet Sekhmet deleted the sekhmet/checkpoint-cache branch September 27, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonustrack bonustrack bonustrack approved these changes

Assignees

@Sekhmet Sekhmet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sekhmet @bonustrack