fix: only optimistically resolve nested entities #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have this optimization that nested entities will resolve id if it's
only requested field without making actual database query.
This might not be ideal, if relation is broken (for example Space references
not existing SpaceMetadata), but can save some queries, so it's mostly
just a convention.
However this ended up also short-circuting requests like this:
```gql
query {
space(id: "eth:doesnotexist") {
id
}
}
```
This commit prevents this from happening, by checking if it was resolved
from parent.
Sekhmet
force-pushed
the
sekhmet/fix-nested-lookup
branch
from
8d4f74c to
7324d25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #296
Depends on: #297
Test plan
Test on this branch https://github.com/checkpoint-labs/checkpoint-template/compare/sekhmet/tt?expand=1
Run this query:
{ user(id: "a") { id } users { info { id } } }First entity doesn't resolve, without this PR it would.