Issue #701: releasenotes builder: release version validation should work on digits #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stoyanK7
commented
Nov 25, 2022
| private static boolean isMinor(long amountOfCommas) { | ||
| return amountOfCommas == 1; | ||
| private static boolean endsWithZero(String str) { | ||
| return !str.isEmpty() && str.charAt(str.length() - 1) == '0'; |
There was a problem hiding this comment.
I know that this method sounds redundant and we could have used built-in str.endsWith("0") but Intellij suggests using this instead so I went with it.
romani
requested changes
Nov 25, 2022
...senotes-builder/src/test/resources/com/github/checkstyle/githubPageBreakingCompatibility.txt
Outdated
Show resolved
Hide resolved
|
@romani ping! |
|
Removed |
stoyanK7
deleted the
issue/701-releasenotes-builder-release-version-validation-should-work-on-digits
branch
|
No idea where those attach_pid files pop from but it happens pretty often and only when working on this project. |
|
we can add it to https://github.com/checkstyle/contribution/blob/master/.gitignore to not bother us next time |
|
Yes, I do use IntelliJ IDEA, thanks for the information! I see other projects having it in their |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #701
For the manual test I modified the script to be pointing to this branch and changed
CS_RELEASE_VERSIONto10.5.0. Runs with no errors: https://github.com/stoyanK7/checkstyle/commit/dee3811dd6eb71765ccf3bc085763cfdf876042bIf I change
CS_RELEASE_VERSIONto10.5.1, it is failing as expected.