Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small parentsUntil fixes #1708

Merged
merged 2 commits into from
Feb 11, 2021
Merged

small parentsUntil fixes #1708

merged 2 commits into from
Feb 11, 2021

Conversation

5saviahv
Copy link
Contributor

@5saviahv 5saviahv commented Feb 1, 2021

  • parentsUntil selector accepts multiple results.
  • parentsUntil filter didnt filter

@5saviahv 5saviahv closed this Feb 3, 2021
@5saviahv 5saviahv deleted the parentsUntil branch February 3, 2021 07:45
@fb55
Copy link
Member

fb55 commented Feb 4, 2021

@5saviahv This is a great find, any reason you closed the PR?

@5saviahv
Copy link
Contributor Author

5saviahv commented Feb 4, 2021

I was panicking when one of my tests fail. Turns out I had typo in tests and it wasn't even pushed github.

I use some jquery tests against cheerio, but since some of them fail, I use them with custom Jest matcher preventing jest hang. I thought I made commit with my custom matcher.

@5saviahv 5saviahv restored the parentsUntil branch February 4, 2021 20:16
@5saviahv 5saviahv reopened this Feb 4, 2021
lib/api/traversing.js Outdated Show resolved Hide resolved
@fb55 fb55 merged commit bf899d5 into cheeriojs:main Feb 11, 2021
@fb55
Copy link
Member

fb55 commented Feb 11, 2021

Nice stuff!

@5saviahv 5saviahv deleted the parentsUntil branch February 11, 2021 02:06
fb55 added a commit that referenced this pull request Feb 11, 2021
Continuation of #1708, fixing up `untilNodes` for `{prev,next}Until`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants