implement chef-server fetcher and reporter #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srenatus
reviewed
Nov 1, 2016
| # TODO: should be available in inspec `json-min` reports out-of-the-box | ||
| # TODO: raise warning when not a compliance-known profile | ||
| def cc_profile_index(profiles) | ||
| cc_profiles = tests_for_runner(profiles).map { |profile| profile[:compliance] if profile[:compliance] }.uniq.compact |
There was a problem hiding this comment.
I think this could be tests_for_runner(profiles).select { |profile| profile[:compliance] }.uniq.compact:
irb(main):001:0> ls = [ { foo: nil }, { bar: 3 }, { foo: 4 }]
=> [{:foo=>nil}, {:bar=>3}, {:foo=>4}]
irb(main):002:0> ls.select {|x| x[:foo] }
=> [{:foo=>4}]
There was a problem hiding this comment.
In this case we would need:
tests_for_runner(profiles).select { |profile| profile[:compliance] }.map { |profile| profile[:compliance].uniq.compact
I think it reads better, although we loop more often. Thanks @srenatus
chris-rock
commented
Nov 1, 2016
| @@ -5,7 +5,7 @@ | |||
| license 'Apache 2.0' | |||
| description 'Allows for fetching and executing compliance profiles, and reporting its results' | |||
| long_description IO.read(File.join(File.dirname(__FILE__), 'README.md')) | |||
| version '2.0.0' | |||
| version '2.0.2' | |||
There was a problem hiding this comment.
do not change the version in this PR
chris-rock
force-pushed
the
chris-rock/chef-server
branch
2 times, most recently
from
f17e426 to
caaff08
Compare
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
chris-rock
force-pushed
the
chris-rock/chef-server
branch
from
caaff08 to
9ee6d0f
Compare
|
👍 on the code, testing against viz -- have to reboot real quick cause everything is hanging |
vjeffrey
reviewed
Nov 1, 2016
| profile_id: profile_id, | ||
| } | ||
| } | ||
| end |
There was a problem hiding this comment.
would prob be cool to have a test on this method someday... :)
|
tested against viz -- all good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #129