Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor reporting #214

Merged
merged 1 commit into from
May 2, 2017
Merged

refactor reporting #214

merged 1 commit into from
May 2, 2017

Conversation

chris-rock
Copy link
Contributor

@chris-rock chris-rock commented Apr 28, 2017 •
edited
Loading

Description

  • splits up all reporters
  • harmonize reporter interface
  • implement webmock for all http reporter

Check List

@chris-rock chris-rock force-pushed the chris-rock/refactor-reporter branch 8 times, most recently from c493381 to 057b196 Compare May 2, 2017 13:12
@chris-rock
refactor reporting
038cd92 
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
@chris-rock chris-rock force-pushed the chris-rock/refactor-reporter branch from 1b121f5 to 038cd92 Compare May 2, 2017 13:57
@arlimus arlimus self-requested a review May 2, 2017 14:12
arlimus
arlimus approved these changes May 2, 2017
View reviewed changes
Copy link
Contributor

@arlimus arlimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge improvement to all the tests!
I really like the split of the reporters to be standalone. Great prep for the next step 👍

@arlimus arlimus merged commit e4e7fe8 into master May 2, 2017
@arlimus arlimus deleted the chris-rock/refactor-reporter branch May 2, 2017 14:13
@arlimus
Copy link
Contributor

arlimus commented May 2, 2017

Kudos Chris!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arlimus arlimus arlimus approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chris-rock @arlimus