This repository has been archived by the owner on Jul 14, 2021. It is now read-only.
CC-14: Create chef-dk gem #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@opscode/client-eng thoughts? |
|
Looks like a good start. Eventually I always rip out a lot of the stuff that bundler generates but we can just do that as we go. |
|
@danielsdeleo I've actually tried to delete the unnecessary things. I believe the only unnecessary thing at this point is |
|
@sersut In addition to the Rakefile, there's stuff like how the gemspec relies on git being present rather than just doing globbing in ruby, etc. But it's all fine for now and we can just fix it when it becomes an issue. |
|
Aahh.. right... Good catch.. I totally forgot about it :) Merging... |
lamont-granquist
added a commit
that referenced
this pull request
Apr 26, 2017
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial chef-dk gem and sub_command infrastructure.