Add cookstyle/chefstyle/foodcritic tests to Travis #1160
Conversation
| @@ -5,4 +5,3 @@ | |||
| description 'Generates Chef code for Chef DK' | |||
| long_description 'Generates Chef code for Chef DK' | |||
| version '0.1.0' | |||
There was a problem hiding this comment.
Maybe we should also be bumping versions of this?
There was a problem hiding this comment.
I'm torn on that. Since we don't really upload it to a Chef Server, and the cookbook itself is already versioned with the ChefDK repo itself, I don't see a huge benefit to the overhead (unless you can think of something).
There was a problem hiding this comment.
I dont know if that would add a lot of value. We don't upload it to a Chef Server, and its already versioned via the ChefDK itself.
tduffield
force-pushed
the
tduffield/fix-code_generator-linting
branch
2 times, most recently
from
5974ba3 to
4ace633
Compare
|
@tas50 brought up a good point, that running chefstyle on the root of this repo will revert the above changes. That being said, we currently don't run chefstyle against this repo. |
Signed-off-by: Tom Duffield <tom@chef.io>
tduffield
force-pushed
the
tduffield/fix-code_generator-linting
branch
2 times, most recently
from
69514f1 to
11729d6
Compare
Signed-off-by: Tom Duffield <tom@chef.io>
tduffield
force-pushed
the
tduffield/fix-code_generator-linting
branch
from
11729d6 to
27e1d4e
Compare
tduffield
changed the title
Signed-off-by: Tom Duffield <tom@chef.io>
Signed-off-by: Tom Duffield <tom@chef.io>
tduffield
force-pushed
the
tduffield/fix-code_generator-linting
branch
from
e8d4b9d to
6388d78
Compare
Signed-off-by: Tom Duffield <tom@chef.io>
| - rvm: 2.3.1 | ||
| env: | ||
| FOODCRITIC: 1 | ||
| script: $(which bundle) exec rake style:foodcritic |
|
thank you for busting them out into their own tasks. |
tas50
added
Expeditor: Skip Changelog
We have these rules, we might as well enforce them upon ourselves (BOBRC).
Fixes #1159