This repository has been archived by the owner on Jul 14, 2021. It is now read-only.
Avoid override existing delivery configuration #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tduffield
reviewed
Feb 8, 2017
| source "delivery-config.json" | ||
| not_if {File.exist?(config_json)} |
There was a problem hiding this comment.
nit: property style here is not_if { File.exist?(config_json) } (mostly for readability)
afiune
force-pushed
the
afiune/COOL-653/do-not-override-config.json
branch
4 times, most recently
from
29aa53c to
3c5b1ed
Compare
added 2 commits
February 8, 2017 17:14
Before this change if a user ran `chef generate build-cookbook .` on a delivery project that has already a `project.toml` and/or `config.json` both files would get overwritten. This change fixes this problem by adding a `not_if` guard. Signed-off-by: Salim Afiune <afiune@chef.io>
Signed-off-by: Salim Afiune <afiune@chef.io>
afiune
force-pushed
the
afiune/COOL-653/do-not-override-config.json
branch
from
3c5b1ed to
7b76e44
Compare
tduffield
approved these changes
Feb 8, 2017
|
pinging @chef/maintainers |
thommay
approved these changes
Feb 13, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this change if a user ran
chef generate build-cookbook .on adelivery project that has already a
project.tomland/orconfig.jsonboth files would get overwritten.
This change fixes this problem by adding a
not_ifguard.Signed-off-by: Salim Afiune afiune@chef.io
Issues Resolved
COOL-653 / ZD 10945
Check List