Updating to use new shells available to windows-guest-branch of test-kitchen #305
Conversation
|
Not really, I just add something like: 🚧 Work In Progress 🚧
|
|
Alternatively, you could feature flag it in some way so that you can just ship it any time, if you think the code is otherwise ready to merge. |
tyler-ball
force-pushed
the
tball/windows-policyfile
branch
from
6fd6d41 to
a60e364
Compare
tyler-ball
force-pushed
the
tball/windows-policyfile
branch
from
37a16c0 to
11bf1f1
Compare
| File.join(provisioner[:chef_omnibus_root], %w[bin chef-client]) | ||
| provisioner. | ||
| remote_path_join(%W[#{provisioner[:chef_omnibus_root]} bin chef-client]). | ||
| tap { |path| path.concat(".bat") if provisioner.windows_os? } |
There was a problem hiding this comment.
Seems like this is something TK should give us for "free" (though it's fine to merge the PR and consider this note something that could be improved later if it's not).
There was a problem hiding this comment.
Do you mean figuring out pathing? The #remote_path_join and #windows_os? are all ready doing most of the heavy lifting. I'll take anything that gets us better/cleaner code!
There was a problem hiding this comment.
@fnichol I'm just thinking I could tell TK "use the default for an omnibus install" and then this provisioner wouldn't need to worry about stuff like Windows vs. not.
|
All my PR comments seem like things that are just rough edges in the latest TK. 👍 on this patch. |
|
Yep, on visual inspection that LGME! 👍 |
Updating to use new shells available to windows-guest-branch of test-kitchen
Update mixlib-shellout to recover from the yanked 1.6.0 version.
EDIT This is ready for merge now that TK 1.4 is in master. TK 1.4 and this will be used in the latest omnibus build of chef-dk.
\cc @danielsdeleo