This repository has been archived by the owner on Jul 14, 2021. It is now read-only.
Don't error when profiling an unborn branch #392
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #364 when you create a repo (
git init
) but don't have a commit, you're on an unborn master branch. Commands such asgit rev-parse HEAD
will fail in such a scenario, which causes most Policyfile commands to fail (when attempting to extract git information about the cookbook). There does not seem to be a canonical way to detect that you're on an unborn branch, git uses the same exit code for all failures, and the error messages printed to stderr do not seem to be stable across git versions. So I settled on feeding the output ofgit symbolic-ref -q HEAD
toshow-ref --verify $SYMBOLIC_REF
(we expect the first command to succeed and the second command to fail on an unborn branch).fixes #364
@chef/client-core @tyler-ball