This repository has been archived by the owner on Jul 14, 2021. It is now read-only.
Add gemspec files to allow bundler to run from the gem #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you do a gem build and install it just to make extra sure this won't cause weirdness with rubygems? I think it's unlikely but it's the only possible thing I would think could go wrong. 👍 if that works. |
|
👍 and feel free to add to the other repos as well if this works. |
Bundler needs all files referred to by the gemspecs to be present to successfully finish resolving Gemfile.
|
@danielsdeleo Good call. I made one more minor change because bundler was unhappy with the lack of warning.txt mentioned in the gemspec (even though it's just a post install step...) Now it it builds, installs and tests. |
ksubrama
pushed a commit
that referenced
this pull request
Oct 9, 2015
Add gemspec files to allow bundler to run from the gem
This was referenced Oct 9, 2015
Merged
Merged
Merged
ksubrama
pushed a commit
that referenced
this pull request
Jan 11, 2016
Fix typo in project location
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @jkeiser @danielsdeleo