Adding a CONTRIBUTING document #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
| 1. When an AWS object supports dependent objects, the resource must also have a `:purge` action which destroys all dependent AWS objects, as well as the specified object. | ||
| 1. This is primarily for development purposes, and should be documented as such. | ||
| 1. The action must print a warning when called, so that users know that the resource does not properly clean up data bag references to purged objects. | ||
| 1. If an object can be tagged in the Amazon Ruby SDK, the resource must have an `aws_tags` attribute. |
There was a problem hiding this comment.
If we're not going to specify that they have to use our tagging module, we should specify the parameters for their aws_tags attributes (probably Hash, but should be explicit).
…n chef-provisioning as well as adds AWS specific acceptance criteria
tyler-ball
force-pushed
the
tball/contributing
branch
from
524d1d7 to
b2ca130
Compare
tyler-ball
added a commit
that referenced
this pull request
Sep 10, 2015
Adding a CONTRIBUTING document
tas50
added
Aspect: Documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on chef-boneyard/chef-provisioning#437
\cc @randomcamel @jkeiser @charlesjohnson