Skip to content
This repository has been archived by the owner on Jun 28, 2018. It is now read-only.

Add libffi to support building chefdk on debian #164

Closed
wants to merge 1 commit into from

Conversation

jordane
Copy link
Contributor

@jordane jordane commented May 16, 2014

On debian the health check fails on libffi, so add it as a dependency when building on debian.

@sethvargo sethvargo changed the title add libffi to support building chefdk on debian Add libffi to support building chefdk on debian May 17, 2014
@@ -46,6 +46,7 @@
override :yajl, version: "1.2.0"
override :zlib, version: "1.2.8"

dependency "libffi" if platform == 'debian'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can actually just say

dependency "libffi" if debian?

on more recent versions of Omnibus 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks!

@sersut
Copy link

sersut commented May 19, 2014

Even tough we don't have plans of supporting chefdk on debian soon, I'm cool with merging this. 👍

/cc: @opscode/client-eng

@sersut
Copy link

sersut commented May 19, 2014

Hrmmmm actually I think we should rather have this dependency @ https://github.com/opscode/omnibus-software/blob/master/config/software/chefdk.rb

@lamont-granquist
Copy link
Contributor

Yeah it would be better to fix the software definition that is causing the libffi dep.

We might be able to --disable-libffi in the software definition to make it go away entirely, and if we can't then the dependency should still definitely go in the software defn. The fact that it only happens on debian is also a bit weird, so all the context of the health_check failure would be useful. Regardless this isn't the right spot for the patch, needs to go into omnibus-software.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants