Change WiX template to deploy powershell wrapper modules. #386
Conversation
|
/cc @jdmundrawala @btm @smurawski @schisamo |
|
Will this work on older versions of Windows? |
|
I think this should be it's own feature. Opt-in sort of thing |
|
@jdmundrawala I can make it a separate feature. @schisamo If the current powershell available doesn't support module autoloading, then the installed files are harmless. We export an extra environment variable but that's it. |
|
@jdmundrawala It's a separate feature now. |
|
👍 |
|
Probably will need to do the same thing for chefdk |
ksubrama
force-pushed
the
ksubrama/ps_module
branch
from
4de33f4 to
0c473cc
Compare
ksubrama
force-pushed
the
ksubrama/ps_module
branch
from
df9263a to
3dc6f77
Compare
|
@jdm This is ready for another look. |
|
You pinged the wrong person |
| </Directory> | ||
| <Directory Id="PSMODULES" Name="modules" > | ||
| <Directory Id="PSMODULESCHEF" Name="chef" > | ||
| <Component Id="ChefPSModuleFile" Guid="{DF0E99BF-1877-4099-85A4-067C84A743F2}" > |
There was a problem hiding this comment.
I don't think we should be reusing guids
|
make sure to run this through the build and make sure it does what you want. |
|
I made a local chef-client build and it seems to deploy things to the right place. Module auto-loading seems to not be triggering though - but if I manually import the module (Import-Module chef), it does work. I think this might be a limitation in powershell when a command of the same name already exists in the path. Asking folks to add Import-Module chef to their ps profiles seems good enough to me for now. If nobody complains, we can auto-add it in the future. |
|
My local chefdk builds seem to work as well! 🚢 |
Change WiX template to deploy powershell wrapper modules.
This needs chef/chef#3339 before it will work.