Ship the Delivery CLI in ChefDK

[schisamo]

After some discussions with the Delivery team this feels like the right place to package the delivery binary. From an end-user perspective it's delightful to not have to install yet another package to get the delivery-cli on your workstation. On the build node side most jobs that the delivery-cli executes rely on the other tools that ship in ChefDK.

A couple of things to note:

• This is *nix ONLY ATM. The Delivery team will work on integrating the Windows support 🔜.
• Rust is needed as a build dependency only. Until the Omnibus framework has first class support for build deps (please see Add support for build dependencies chef/omnibus#483) we just remove Rust (and Cargo) from the install dir before running the health check or creating the final package.

Assuming everyone is happy with this approach I'll also update chef verify to be aware of the delivery binary.

/cc @chef/ociv @chef/delivery @chef/client-core @fnichol @tyler-ball @cwebberOps @adamhjk

[danielsdeleo]

Where does this end up in the build order? I'd like rust to be as early as possible so we cache it more often.

[schisamo]

@danielsdeleo I'm not sure that caching Rust matters all that much as we are just extracting pre-compiled binaries.

[jaym]

wouldn't it be better to have rust as part of our builders instead of in here? For example, we don't install gcc (except on windows where we want to ship it) as part of the omnibus phase

[schisamo]

@jdmundrawala That approach makes it very hard for project maintainers to rev the version of a build dependency like rust. It is also desirable to have ALL of a projects required dependencies (traditional or build) declared in a single location. If we introduce first class build deps into the Omnibus DSL we may declare things like GCC, @scotthain has toyed around with this very thing on our more esoteric Unix platforms.

[wk8]

That definition could arguably be made part of omnibus-software ?

[schisamo]

@wk8 Definitely. I plan on moving it once we work all the kinks out.

[tyler-ball]

👍

[wk8]

One minor comment, otherwise LGTM

[MattVonVielen]

In light of us not tagging releases of delivery-cli, 👍

[christophermaier]

👍

[tyler-ball]

👍 LGTM!

[schisamo]

I'll merge this once master is green again and I can get a test build all the way through.

[schisamo]

This looks good from a CI perspective: http://manhattan.ci.chef.co/job/chefdk-build/339/