Update to Chef 12.5 custom resources

[detjensrobert]

Signed-off-by: Robert Detjens detjensrobert@osuosl.org

Description

Instead of using Chef 11 resource/providers, switch to Chef 12 custom resources. This also enables unified_mode for Chef 17 compatibility.

Issues Resolved

Fixes #217.

Check List

• All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
• New functionality includes testing.
• New functionality has been documented in the README if applicable
• All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

[tas50]

Sadly I'm going to have to close this out. We have a large number of folks trying to use this today to migrate off pre-12.5 releases. It's sad, but the reality we have.

[jeffbyrnes]

@tas50 wouldn't those folks be able to stick with an older version of this cookbook to do those migrations?

[detjensrobert]

What's the plan for unified_mode Chef 17/18 compatibility with this cookbook if this PR is closed? Does unified_mode work with the legacy LWRPs?

[tas50]

@detjensrobert We can make it work only on systems with unified mode.

[jeffbyrnes]

@tas50 wouldn’t folks be able to pin to a version that works w/ Chef < 12.5 to use it to migrate? Or am I missing something?

[tas50]

@jeffbyrnes We're trying to build a single cookbook for all releases and pre-12.9 (when custom resources really worked reliably) is a pretty common upgrade path for customers. This cookbook maintains compatibility all the way back to 11.x for that reason.

[jeffbyrnes]

Ok, makes sense! Thanks.

[lamont-granquist]

unified_mode false if defined?(:unified_mode) is probably the way to solve this