Normalize Bento templates #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The normalize subcommand does 2 things: 1. Run `packer validate` to verify the integrity of the template 2. Run `packer fix` to normalize the JSON format for a higher degree of consistency A summary of all changes templates are printed at the end of the normalize execution, making this command useful in CI.
|
@yzl Ready for a quick review. |
| @@ -69,10 +70,10 @@ class Options | |||
| }, | |||
| argv: templates_argv_proc | |||
| }, | |||
| fix: { | |||
There was a problem hiding this comment.
I'm wondering if we should deprecate/warn but not remove the 'fix' CLI command in favor of making it an alias of 'normalize' at least for a little while. I may be being more conservative than is needed though. I feel like as small as it is, it is technically a 'breaking' change.
There was a problem hiding this comment.
At the moment, the bin/bento code has only been in master about a week (and still not documented). I could add an alias here, but was hoping it was under (or not) used.
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a modified subcommand called
normalize(formerlyfix) which will validate each template and then runs it throughpacker fixto normalize the JSON output formatting. The subcommand creates a report at the end containing a list of all templates that were modified in the normalize execution, making this a candidate for running in CI.