Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

squashed commit to add all the qemu options on all the systems. #374

Closed
wants to merge 1 commit into from

Conversation

dmlb2000
Copy link
Contributor

This adds the qemu options for all systems. Should be "squashed" I didn't use the git features for this I just did a diff and committed it, it was easier to inspect the diff that way.

@mattiascockburn
Copy link
Contributor

With the AutoYaST fixes from #373 qemu build works flawlessly for SLES 11.3 (i386/x86_64) and SLES12. 👍

@dmlb2000
Copy link
Contributor Author

@mattiasgiese #373 Should also allow the qemu specific disk_interface option to opensuse to be removed like it is for sles since they are related distributions correct?

@mattiascockburn
Copy link
Contributor

Yep, starting with SLES 11 SP2 and openSUSE 12 YaST will take the first device found if no specific one is given in the bootloader/partitioning section.

@mattiascockburn
Copy link
Contributor

I will go ahead and create a PR for openSUSE.

@johnbellone
Copy link

👍

@cheeseplus
Copy link
Contributor

@dmlb2000 could you rebase this one? We had a bunch of other commits related to the other builders that took priority but I don't see any reason why we can't add QEMU builders.

@dmlb2000
Copy link
Contributor Author

Looks like there's a lot of changes I'll take a bit to make a new diff...

@cheeseplus
Copy link
Contributor

Sorry about that it was more about fixing up things that were broken than adding new features but just wanted folks to know I hadn't forgotten.

@dmlb2000 dmlb2000 closed this Sep 27, 2015
@dmlb2000 dmlb2000 deleted the squashed_master branch September 27, 2015 06:22
@dmlb2000
Copy link
Contributor Author

Hmmm, I recreated the branch to resquash the commit... I'll open a new pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants