Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dhcp settings cleanup in Ubuntu 12.04 and higher #498

Merged
merged 1 commit into from
Nov 27, 2015

Conversation

legal90
Copy link
Contributor

@legal90 legal90 commented Nov 24, 2015

There is a typo. It should be /var/lib/dhcp/*, like in the similar script for Debian: https://github.com/chef/bento/blob/250efaa/scripts/debian/networking.sh#L8

@tersmitten
Copy link
Contributor

In Ubuntu 10.04 it used to be dhcp3. But that's probably not a problem :-)

@legal90
Copy link
Contributor Author

legal90 commented Nov 26, 2015

Oh, is it? Sorry, I didn't know about that.
If we care about this case, then I can change my PR by adding some regex there

@tersmitten
Copy link
Contributor

ubuntu-10.04-amd64.json is still in the repository. Let's make sure both cases work :-)

@cheeseplus
Copy link
Contributor

@tersmitten +1- although we'll be moving any deprecated platforms into a separate folder and labeling as such, we definitely want things to still work because folks will for sure continue to use EoL platforms

@legal90 legal90 changed the title Fix typo in scripts/ubuntu/networking.sh Fix dhcp settings cleanup in Ubuntu 12.04 and higher Nov 26, 2015
@legal90
Copy link
Contributor Author

legal90 commented Nov 26, 2015

@cheeseplus Done. I've kept the previous dir name and just added /var/lib/dhcp/*

@cheeseplus
Copy link
Contributor

lgtm

cheeseplus pushed a commit that referenced this pull request Nov 27, 2015
Fix dhcp settings cleanup in Ubuntu 12.04 and higher
@cheeseplus cheeseplus merged commit 940cb43 into chef:master Nov 27, 2015
@legal90 legal90 deleted the fix-script-typo branch November 27, 2015 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants