[macos-10.12] Allow Packer to pick up memory user var. #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason with Pack 0.12.3, the current `"memory"` user variable is not being picked up and a default value of `1024` is always being used, leading to macOS 10.12 not being able to finish its installation. For some reason, changing the user variable from `"memory"` to almost anything else (in this case, `"memsize"`) allows the user variable to be picked up. Note that this was observed with the `vmware-iso` builder and may be the only affected one. I verified this behavior by running: ``` env PACKER_LOG=1 bundle exec bento build --only=vmware-iso --debug macos-10.12 ``` Signed-off-by: Fletcher Nichol <fnichol@nichol.ca>
|
This seems really weird but don't see any open issues on packer regarding it yet, will try to verify but should be safe enough for merge. Curious if it happens for other platforms too. |
|
Going to just merge this one for now as I trust it enough to merge. I'll be testing OSX boxes on another pass and will verify then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not 100% sure if this is an issue--it might need to be confirmed but I could not finish building this box without this fix…
For some reason with Pack 0.12.3, the current
"memory"user variableis not being picked up and a default value of
1024is always beingused, leading to macOS 10.12 not being able to finish its installation.
For some reason, changing the user variable from
"memory"to almostanything else (in this case,
"memsize") allows the user variable to bepicked up.
Note that this was observed with the
vmware-isobuilder and may be theonly affected one. I verified this behavior by running: