Fix cookbook dependency version validation against chef's required format to berks upload #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nikhil2611 <nikhilgupta2102@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
|
SonarQube Quality Gate
|
ashiqueps
approved these changes
May 22, 2023
vkarve-chef
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Here, we add a cookbook version dependency validation that reuses the existing version validation logic of the Chef gem in ::Chef::Version.
This will fix the Invalid Cookbook dependency allowed to be uploaded using berks upload
Issues Resolved
Fixes: https://github.com/chef/customer-bugs/issues/686
Check List