Change policyfile generator to use 'policyfiles' directory #1590
Conversation
… 'policies' directory Signed-off-by: Jon Cowie <jonlives@gmail.com>
jonlives
changed the title
|
@jonlives can you please change the directories used in this README.md too? |
Signed-off-by: Jon Cowie <jonlives@gmail.com>
|
@jeremiahsnapp I've made the README changes as requested :) |
|
The directory is also in the |
Signed-off-by: Jon Cowie <jonlives@gmail.com>
|
Fixed thanks @danielsdeleo, thanks for the catch! |
Signed-off-by: Jon Cowie <jonlives@gmail.com>
There was a problem hiding this comment.
The change LGTM. My only question is since we're changing the functionality of this tool does that need to be in a major version release?
This seems small enough of a change, and its in a generator (which I hope people aren't using in a CI flow) that it could just go in a minor change. What say y'all?
|
@tyler-ball I think this could go into a minor release but I don't mind waiting if we need to |
|
Given that the generators are pretty busted in a number of fundamental ways (16 open issues last I checked) I don't think we need to wait for a major for any improvements. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Change policyfile generator to use 'policyfiles' directory instead of 'policies' directory.
This change comes from the discussion in habitat-sh/core-plans#1544 around standardising on the name of the directory across all Chef software, and the feeling that using the name 'policyfiles' matched the name of the feature better.
Signed-off-by: Jon Cowie jonlives@gmail.com
Description
It changes the name of the policyfiles directory created by chef-dk generator commands from 'policies' to 'policyfiles'. It also fixes the test that checks for that name.
Check List