This repository has been archived by the owner on Jul 14, 2021. It is now read-only.
Include more information about the policy in chef push output
#1704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderanger
approved these changes
Sep 18, 2018
|
@danielsdeleo Specs are mad |
The goal of this change is to surface more information so that it's easier for users to detect a certain class of mistakes (e.g., run `chef push` from the wrong working directory) and to produce a more useful log of what `chef push` did when run in a Ci context. Possible downside is that the extra information may be offputting to novice users, but that's probably a wash as some novices would likely appreciate the additional detail about the consequences of the command they are running. Signed-off-by: Daniel DeLeo <dan@chef.io>
danielsdeleo
force-pushed
the
dan/more-verbose-push
branch
from
7d00ac6 to
bd39a0b
Compare
|
@tas50 derp, did a small reorganization and forgot to re-run. Should be fine now |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The goal of this change is to surface more information so that it's
easier for users to detect a certain class of mistakes (e.g., run
chef pushfrom the wrong working directory) and to produce a moreuseful log of what
chef pushdid when run in a Ci context.Possible downside is that the extra information may be offputting to
novice users, but that's probably a wash as some novices would likely
appreciate the additional detail about the consequences of the command
they are running.
Old output:
New output:
Issues Resolved
Inspired by a debugging session in Chef Software internal slack.
Check List