This repository has been archived by the owner on Jul 14, 2021. It is now read-only.
Appbundler inspec-bin not inspec #2043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -75,7 +75,7 @@ | |||
| appbundle "chef", lockdir: project_dir, gem: "chef", without: %w{integration docgen maintenance ci travis}, env: env | |||
There was a problem hiding this comment.
you need to appbundle gem: "chef-bin" instead of "chef" here.
There was a problem hiding this comment.
(actually it should be in addition to, we still need gem: "chef" for knife)
There was a problem hiding this comment.
We're not pulling in chef 15 yet
omnibus/config/software/chef-dk.rb
Outdated
| @@ -75,7 +75,7 @@ | |||
| appbundle "chef", lockdir: project_dir, gem: "chef", without: %w{integration docgen maintenance ci travis}, env: env | |||
| appbundle "foodcritic", lockdir: project_dir, gem: "foodcritic", without: %w{development}, env: env | |||
| appbundle "test-kitchen", lockdir: project_dir, gem: "test-kitchen", without: %w{changelog debug docs}, env: env | |||
| appbundle "inspec", lockdir: project_dir, gem: "inspec", without: %w{deploy tools maintenance integration}, env: env | |||
| appbundle "inspec-bin", lockdir: project_dir, gem: "inspec", without: %w{deploy tools maintenance integration}, env: env | |||
There was a problem hiding this comment.
this needs to be gem: "inspec-bin", i am not clear any more on what the first arg even does here....
Signed-off-by: Tim Smith <tsmith@chef.io>
|
merging based on slack approval |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets us a working inspec binary with InSpec 4.0.
Signed-off-by: Tim Smith tsmith@chef.io