Skip to content
This repository has been archived by the owner on Jul 14, 2021. It is now read-only.

Fix the build arguments in the Dockerfile #2228

Merged
merged 1 commit into from
Aug 22, 2019
Merged

Conversation

tduffield
Copy link
Contributor

@tduffield tduffield commented Aug 22, 2019

Description

Fix the build arguments in the Dockerfile

We need to support the prefixed EXPEDITOR_ build arguments in our
Dockerfile. We are leaving the non-prefixed arguments in there for
back-compat.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

We need to support the prefixed `EXPEDITOR_` build arguments in our
Dockerfile. We are leaving the non-prefixed arguments in there for
back-compat.

Signed-off-by: Tom Duffield <tom@chef.io>
@tduffield tduffield requested review from a team as code owners August 22, 2019 15:44
@tas50 tas50 merged commit f68fd93 into master Aug 22, 2019
@chef-ci chef-ci deleted the tduffield/fix-dockerfile branch August 22, 2019 15:48
@lock
Copy link

lock bot commented Oct 21, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants