Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Omnibus Software #127

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Updating Omnibus Software #127

merged 1 commit into from
Jun 12, 2024

Conversation

johnmccrae
Copy link
Contributor

@johnmccrae johnmccrae commented Jun 11, 2024

Description

This is a crazy PR: So, we have this PR in omnibus-software here. That patches resolv.rb to overcome a weird error. The current version of Omnibus-Software in Chef-Foundation does not contain that update. As a result, 1) Various builders/testers that use Chef-18 to build Chef-17 throw an encoding error on the Windows nodes when testing some things and 2) Chef-18 is vulnerable to the same issue although it has not been reported yet.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Signed-off-by: John McCrae <john.mccrae@progress.com>
@johnmccrae johnmccrae requested a review from a team as a code owner June 11, 2024 21:57
@poorndm poorndm merged commit 8629f17 into main Jun 12, 2024
5 checks passed
@johnmccrae johnmccrae deleted the jfm/chef18-resolv.rb branch June 13, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants