Fix the Chocolatey-missing error again #4621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randomcamel
force-pushed
the
cd/fix-choco-error
branch
from
06be45c to
768ca5b
Compare
randomcamel
changed the title
| # if this check is in #define_resource_requirements, it won't get | ||
| # run before choco.exe gets called from #load_current_resource. | ||
| exe_path = ::File.join(choco_install_path.to_s, "bin", "choco.exe") | ||
| if !::File.exist?(exe_path) |
There was a problem hiding this comment.
looks like some indentation issues here. Also unless may be clearer than if !.
There was a problem hiding this comment.
yeah that'll be a rubocop violation at some point in the not too distant future...
randomcamel
force-pushed
the
cd/fix-choco-error
branch
from
d7dda1d to
37baee5
Compare
|
👍 |
1 similar comment
|
👍 |
btm
added a commit
that referenced
this pull request
Feb 26, 2016
Fix the Chocolatey-missing error again
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation (in
define_resource_requirements) failed acceptance testing becausechoco.exegets called before that, inload_current_resource, so the detection needs to be a bit lower-level.This includes a spec that replicates the acceptance test (by calling
load_current_resource).