Core: Fix bug where Access Controls on existing symlink resources would be ignored on first chef-client run #5616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevendanna
reviewed
Dec 5, 2016
| @@ -121,6 +121,12 @@ def action_create | |||
| file_class.symlink(canonicalize(@new_resource.to), @new_resource.target_file) | |||
| Chef::Log.debug("#{@new_resource} created #{@new_resource.link_type} link from #{@new_resource.target_file} -> #{@new_resource.to}") | |||
| Chef::Log.info("#{@new_resource} created") | |||
| # file_class.symlink will create the link with default access controls. | |||
| # This means that the access controls of the file could be different | |||
| # thank those captured during the initial evaluation of current_resource. | |||
thommay
approved these changes
Dec 6, 2016
When a link resource needs to change its destination, there was a bug in the logic flow that would cause the access controls on the resulting symlink to revert to the default access controls. This commit closes that hole by re-evaluating the current access controls after creating the new symlink. Signed-off-by: Tom Duffield <tom@chef.io>
tduffield
force-pushed
the
COOL-614/tduffield/link-keep-access-controls
branch
from
3ea8ee7 to
6dc4505
Compare
tduffield
changed the title
tduffield
changed the title
mwrock
approved these changes
Dec 6, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a link resource needs to change its destination, there was a bug in
the logic flow that would cause the access controls on the resulting
symlink to revert to the default access controls. This commit closes
that hole by re-evaluating the current access controls after creating
the new symlink.
Issues Resolved
Check List