Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintain compat with old zypper_repo resource used in cookbooks #6318

Merged
merged 2 commits into from
Aug 11, 2017
Merged

Maintain compat with old zypper_repo resource used in cookbooks #6318

merged 2 commits into from
Aug 11, 2017

Conversation

tas50
Copy link
Contributor

@tas50 tas50 commented Aug 10, 2017

Signed-off-by: Tim Smith tsmith@chef.io

@tas50
Maintain compat with old zypper_repo resource used in cookbooks
5bba679 
Signed-off-by: Tim Smith <tsmith@chef.io>
coderanger
coderanger approved these changes Aug 10, 2017
View reviewed changes
Copy link
Contributor

@coderanger coderanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related: we don't actually need the provides :zypper_repository, it's redundant with resource_name.

@tas50
Copy link
Contributor Author

tas50 commented Aug 10, 2017

@lamont-granquist mentioned they were different when I asked. We have them everywhere else. If we wanna nuke them we should nuke them all.

@tas50
Don't use provides twice
fe5e560 
Signed-off-by: Tim Smith <tsmith@chef.io>
coderanger
coderanger approved these changes Aug 10, 2017
View reviewed changes
Copy link
Contributor

@coderanger coderanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even more 👍

@tas50 tas50 merged commit 852c947 into master Aug 11, 2017
@tas50 tas50 deleted the zypper2 branch August 11, 2017 01:04
@chef chef locked and limited conversation to collaborators Feb 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@coderanger coderanger coderanger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tas50 @coderanger