Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHEF-1921 Fixed the knife-cloud verify test failure #180

Merged
merged 9 commits into from
Oct 25, 2023
Merged

CHEF-1921 Fixed the knife-cloud verify test failure #180

merged 9 commits into from
Oct 25, 2023

Conversation

nikhil2611
Copy link
Contributor

Description

updated ruby version to 3.1 and removed 2.7 and 3.0 ruby verify pipeline as the latest chef 18.2.7 supports ruby >= 3.1

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@nikhil2611
updated ruby version and verify pipeline
c7e11b1 
Signed-off-by: nikhil2611 <nikhilgupta2102@gmail.com>
@nikhil2611
added knife dependency
0455342 
Signed-off-by: nikhil2611 <nikhilgupta2102@gmail.com>
@sonarqube-for-infrastructure-prod
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nikhil2611
updated ruby verify pipeline image
6d98e6a 
Signed-off-by: nikhil2611 <nikhilgupta2102@gmail.com>
@nikhil2611
updated the Gemfile
6fa97fe 
Signed-off-by: nikhil2611 <nikhilgupta2102@gmail.com>
@nikhil2611
updated pipeline and gemfile
410c85d 
Signed-off-by: nikhil2611 <nikhilgupta2102@gmail.com>
@nikhil2611
updated rspec-mocks version
1a9229d 
Signed-off-by: nikhil2611 <nikhilgupta2102@gmail.com>
@nikhil2611
rspec-mocks chefstyle fix
194fab1 
Signed-off-by: nikhil2611 <nikhilgupta2102@gmail.com>
@nikhil2611
added win image
a392044 
Signed-off-by: nikhil2611 <nikhilgupta2102@gmail.com>
@nikhil2611
updated Gemfile
47d897a 
Signed-off-by: nikhil2611 <nikhilgupta2102@gmail.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nikhil2611 nikhil2611 added the Expeditor: Skip All Used to skip all merge_actions. label Oct 25, 2023
@nikhil2611 nikhil2611 merged commit dce0593 into main Oct 25, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanjain-progress sanjain-progress sanjain-progress approved these changes

@ashiqueps ashiqueps ashiqueps approved these changes

Assignees
No one assigned
Labels
Expeditor: Skip All Used to skip all merge_actions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikhil2611 @ashiqueps @sanjain-progress