Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make public_ip work for any case 'none' at 'instance_access_configs_for' #106

Merged
merged 7 commits into from
Oct 23, 2016

Conversation

abhishekkr
Copy link
Contributor

version in use: knife-google (2.0.0)

Running knife google server create ...--gce-public-ip none command still attached Ephemeral(default) public-ip to the new node.
Making match non-case-sensitive at 'google_service.rb:instance_access_configs_for' fixed it.

Here is the PR for it, also made it similar to 'valid_public_ip_setting?' handling of case.

@abhishekkr
Copy link
Contributor Author

abhishekkr commented Apr 28, 2016

the error check is for Ruby 2.0.0

An error occurred while installing chef-zero (4.6.2), and Bundler cannot continue

@abhishekkr abhishekkr closed this Apr 28, 2016
@abhishekkr
Copy link
Contributor Author

to re-run Travis

@abhishekkr abhishekkr reopened this Apr 28, 2016
@hrez
Copy link

hrez commented Oct 13, 2016

Thanks for the fix. Why isn't it still merged to the master? It's obviously a bug.

@jjasghar
Copy link

@abhishekkr can you rebase off master please?

@jjasghar
Copy link

With our new policy please use the DCO signing process.

For a detailed description or you can just do:

$ git commit -s
$ #Or
$ git commit --signoff

If you already have the commit, use git commit --amend or git rebase -i to edit your commit message, and add the above signoff line.

Or if you want a more perminant option the following is a way to set it forever:

$ git config commit.gpgsign true

Signed-off-by: AbhishekKr <abhikumar163@gmail.com>
@abhishekkr
Copy link
Contributor Author

@jjasghar had already pushed required diffs before, so pushed in an empty commit signed

@abhishekkr
Copy link
Contributor Author

@jjasghar do I need to do anything else

@jjasghar jjasghar merged commit a9eedaf into chef:master Oct 23, 2016
@jjasghar
Copy link

I'll be releasing a new version of the gem soon.

@jjasghar
Copy link

jjasghar commented Nov 8, 2016

I have released v3.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants