-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make public_ip work for any case 'none' at 'instance_access_configs_for' #106
Conversation
also similar to 'valid_public_ip_setting?' handling of non-case-sensitive
the error check is for Ruby 2.0.0
|
to re-run Travis |
…ires Ruby version >= 2.1.0 removed Ruby 2.0.0, added Ruby 2.3.0
Thanks for the fix. Why isn't it still merged to the master? It's obviously a bug. |
@abhishekkr can you rebase off master please? |
With our new policy please use the DCO signing process. For a detailed description or you can just do:
If you already have the commit, use git commit --amend or git rebase -i to edit your commit message, and add the above signoff line. Or if you want a more perminant option the following is a way to set it forever: $ git config commit.gpgsign true |
Signed-off-by: AbhishekKr <abhikumar163@gmail.com>
@jjasghar had already pushed required diffs before, so pushed in an empty commit signed |
@jjasghar do I need to do anything else |
I'll be releasing a new version of the gem soon. |
I have released v3.1.0 |
version in use: knife-google (2.0.0)
Running
knife google server create ...--gce-public-ip none
command still attached Ephemeral(default) public-ip to the new node.Making match non-case-sensitive at 'google_service.rb:instance_access_configs_for' fixed it.
Here is the PR for it, also made it similar to 'valid_public_ip_setting?' handling of case.