[MSYS-1040] Added validation for image_os_type and connection_port #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for Travis failure Signed-off-by: Kapil Chouhan <kapil.chouhan@msystechnologies.com>
Signed-off-by: NAshwini <ashwini.nehate@msystechnologies.com>
Signed-off-by: NAshwini <ashwini.nehate@msystechnologies.com>
NAshwini
changed the title
Signed-off-by: Kapil Chouhan <kapil.chouhan@msystechnologies.com>
kapilchouhan99
force-pushed
the
Kapil/Added_validation_for_image_os_type_and_connection_port
branch
from
d5d30e4 to
9a015fd
Compare
tas50
reviewed
Jul 2, 2019
| ui.warn("Auto-migrate disabled for preemptible instance") if preemptible? && locate_config_value(:auto_migrate) | ||
| ui.warn("Auto-restart disabled for preemptible instance") if preemptible? && locate_config_value(:auto_restart) | ||
| ui.warn("[DEPRECATED] --bootstrap-protocol option is deprecated. Use --connection-protocol option instead.") if locate_config_value(:bootstrap_protocol) | ||
| ui.warn("[DEPRECATED] --bootstrap-protocol option is deprecated. Use --connection-protocol option instead.") if locate_config_value(:bootstrap_protocol) |
There was a problem hiding this comment.
Now that we require Chef 15 we may be able to use the new deprecation functionality in mixlib-cli to handle the deprecation right in the option definition. See how we did it directly in knife here: https://github.com/chef/chef/pull/8637/files
Signed-off-by: Kapil Chouhan <kapil.chouhan@msystechnologies.com>
kapilchouhan99
force-pushed
the
Kapil/Added_validation_for_image_os_type_and_connection_port
branch
from
9a015fd to
793f099
Compare
Signed-off-by: Kapil Chouhan <kapil.chouhan@msystechnologies.com>
btm
approved these changes
Aug 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kapil Chouhan kapil.chouhan@msystechnologies.com
Description
--connection_protocol winrmor--connection_protocol ssh, at that time we need to reset windows instance password, so that's why at this stage we need to useimage_os_typeimage_os_typeandconnection_port