Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore directory traversing file_names in an tar #6

Merged
merged 1 commit into from
Feb 2, 2017

Conversation

thommay
Copy link
Contributor

@thommay thommay commented Feb 2, 2017

It's possible to construct tar archives with entries that contain path
names that traverse outside the target directory. We will now just
ignore those entries

Signed-off-by: Thom May thom@chef.io

Copy link

@robbkidd robbkidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:hugefan:

Copy link

@stevendanna stevendanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

It's possible to construct tar archives with entries that contain path
names that traverse outside the target directory. We will now just
ignore those entries

Signed-off-by: Thom May <thom@chef.io>
@thommay thommay merged commit a9994e7 into master Feb 2, 2017
@thommay thommay added the Type: Bug Does not work as expected. label Feb 2, 2017
@carnil
Copy link

carnil commented Jul 16, 2017

This issue has been assigned CVE-2017-1000026

@chef chef locked and limited conversation to collaborators Nov 16, 2017
@tas50 tas50 deleted the tm/fix_directory_traversal branch July 25, 2018 23:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Bug Does not work as expected.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants