add install.sh proxy support #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrightp
force-pushed
the
wrightp/proxy-options
branch
from
03b70e1 to
391d3b6
Compare
wrightp
changed the title
scotthain
approved these changes
Sep 12, 2017
schisamo
approved these changes
Sep 12, 2017
wrightp
force-pushed
the
wrightp/proxy-options
branch
from
391d3b6 to
90c5fc4
Compare
schisamo
approved these changes
Sep 14, 2017
Signed-off-by: Patrick Wright <patrick@chef.io>
wrightp
force-pushed
the
wrightp/proxy-options
branch
from
90c5fc4 to
a2e58a6
Compare
rhass
approved these changes
Sep 14, 2017
tduffield
approved these changes
Sep 14, 2017
Signed-off-by: Patrick Wright <patrick@chef.io>
Signed-off-by: Patrick Wright <patrick@chef.io>
|
Does this resolve #201? |
tas50
added
Expeditor: Bump Version Minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proxy tests could be optimized, but it's time to get this change out to the world. I've done manual testing and added some functional proxy tests.
Signed-off-by: Patrick Wright patrick@chef.io