add #download_artifact method to Mixlib::Install API #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrightp
force-pushed
the
wrightp/download
branch
from
e10003c to
58a98b7
Compare
wrightp
changed the title
rhass
reviewed
Oct 9, 2017
| file = File.join(directory, File.basename(artifact.url)) | ||
|
|
||
| uri = URI.parse(artifact.url) | ||
| Net::HTTP.start(uri.host) do |http| |
There was a problem hiding this comment.
Won't this have issues with proxies since we are calling Net::HTTP rather than OpenURI?
README.md
Outdated
| Download a specific artifact to a configurable location. All platform options (platform, platform_version, architecture) are required in order to filter a single artifact. | ||
| ```ruby | ||
| # detect platform and download to "/tmp" | ||
| Mixlib::Install.new(product_name: "chefdk", channel: :stable).detect_platform.download_artifact("/tmp") |
There was a problem hiding this comment.
In the event the example is cargo culted; Dir.tmpdir is a better non-platform specific path rather than "/tmp".
There was a problem hiding this comment.
I see what you mean now. I'll update this
Signed-off-by: Patrick Wright <patrick@chef.io>
wrightp
force-pushed
the
wrightp/download
branch
from
58a98b7 to
94d2112
Compare
tas50
added
Expeditor: Bump Version Minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Patrick Wright patrick@chef.io