update amazon platform mapping to support Versions 1, 2, and 2 RCs #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Wright <patrick@chef.io>
|
@chef/jex-team @tas50 Please review. Thank you. |
|
I've tested this on amazon linux platforms. |
|
I'm really confused by this PR. It goes against the meeting we had. We had agreed to keep the logic from being client side, but this moves the Amazon platform mapping back to the client side where we can't easily update it in the future if something changes on the OS side. Additionally we lose the ability to know how many people are actually requesting packages on Amazon, which is a big question we keep getting asked at a management level. It all looks like RHEL6/7 with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Patrick Wright patrick@chef.io