Rename suse platform to opensuseleap #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This aligns the names we use in the install script with ohai. We're already remapping suse to sles in omnitruck. I added a remap for opensuseleap to sles in a PR there. This is a baby step towards a single list of platform names. Signed-off-by: Tim Smith <tsmith@chef.io>
wrightp
reviewed
Aug 27, 2018
There was a problem hiding this comment.
Probably need to update this line as well:
https://github.com/chef/mixlib-install/pull/268/files#diff-d9c7a898e10dc5d21d5a97d976c5a4d9R159
Signed-off-by: Tim Smith <tsmith@chef.io>
|
Updated @wrightp |
wrightp
approved these changes
Aug 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns the names we use in the install script with ohai. We're already remapping suse to sles in omnitruck. I added a remap for opensuseleap to sles in a PR there. This is a baby step towards a single list of platform names.
Signed-off-by: Tim Smith tsmith@chef.io